Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [plugins/prometheus] fixes for phases/shouldObserve for Yoga #2326

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

EmrysMyrddin
Copy link
Collaborator

Minor fixes required to propagate phases/shouldObserve new config to Yoga plugin.

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 78ea8d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/graphql-jit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 12, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/graphql-jit 8.0.4-alpha-20241119110638-78ea8d1b8abb6ba89f9a443e4742e9c43bb1b145 npm ↗︎ unpkg ↗︎
@envelop/prometheus 12.0.0-alpha-20241119110638-78ea8d1b8abb6ba89f9a443e4742e9c43bb1b145 npm ↗︎ unpkg ↗︎

@theguild-bot
Copy link
Collaborator

theguild-bot commented Nov 12, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 770688     ✗ 0     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: 100.00% ✓ 165372     ✗ 0     
     ✓ { mode:envelop-cache-jit }.......................: 100.00% ✓ 338016     ✗ 0     
     ✓ { mode:envelop-just-cache }......................: 100.00% ✓ 165936     ✗ 0     
     ✓ { mode:graphql-js }..............................: 100.00% ✓ 101364     ✗ 0     
     data_received......................................: 2.9 GB  25 MB/s
     data_sent..........................................: 168 MB  1.4 MB/s
     envelop_init.......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_execute....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_parse......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_validate...................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.82µs  min=1.18µs   med=2.59µs  max=3.6ms    p(90)=3.46µs  p(95)=3.85µs 
     http_req_connecting................................: avg=13ns    min=0s       med=0s      max=700.12µs p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.82ms  min=164.99µs med=2.74ms  max=40.3ms   p(90)=5.21ms  p(95)=6.05ms 
       { expected_response:true }.......................: avg=2.82ms  min=164.99µs med=2.74ms  max=40.3ms   p(90)=5.21ms  p(95)=6.05ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.36ms  min=490.19µs med=3ms     max=22.31ms  p(90)=5.65ms  p(95)=6.16ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.46ms  min=164.99µs med=1.22ms  max=17.38ms  p(90)=2.45ms  p(95)=2.61ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.34ms  min=419.43µs med=2.97ms  max=22.58ms  p(90)=5.62ms  p(95)=6.12ms 
     ✓ { mode:graphql-js }..............................: avg=5.64ms  min=707.47µs med=4.85ms  max=40.3ms   p(90)=9.38ms  p(95)=10.2ms 
     http_req_failed....................................: 0.00%   ✓ 0          ✗ 385344
     http_req_receiving.................................: avg=35.69µs min=13.56µs  med=30.89µs max=14.65ms  p(90)=47.39µs p(95)=50.87µs
     http_req_sending...................................: avg=12.98µs min=4.11µs   med=9.83µs  max=15.03ms  p(90)=19.31µs p(95)=20.88µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.77ms  min=132.9µs  med=2.69ms  max=40.22ms  p(90)=5.15ms  p(95)=6ms    
     http_reqs..........................................: 385344  3211.09397/s
     iteration_duration.................................: avg=3.1ms   min=353.77µs med=2.99ms  max=40.88ms  p(90)=5.5ms   p(95)=6.34ms 
     iterations.........................................: 385344  3211.09397/s
     vus................................................: 10      min=10       max=10  
     vus_max............................................: 20      min=20       max=20  

Copy link
Contributor

github-actions bot commented Nov 12, 2024

💻 Website Preview

The latest changes are available as preview in: https://c1bd490b.envelop.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants