-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroh-net): Add helper fn to enable n0 discovery publishing and resolving #2775
base: main
Are you sure you want to change the base?
Conversation
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2775/docs/iroh/ Last updated: 2024-10-17T09:39:43Z |
discovery_local_network discovery_dht
efbac73
to
b09c11b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement! Even if the exactly locations of things may change before 1.0. Any reason this is still in draft?
I don't think it is due to code quality, just that we had a long discussion what we want to do about discovery. |
Co-authored-by: Floris Bruynooghe <[email protected]>
Co-authored-by: Floris Bruynooghe <[email protected]>
Co-authored-by: Floris Bruynooghe <[email protected]>
Description
Add a helper fn to configure n0 default discovery without having to resort to having to combine a custom discovery service.
becomes
Breaking Changes
None
Notes & open questions
Should this be on or off by default?
Does anybody hate the name?
Should we also add fns for "just publish" or "just resolve" that I frequently need?
Change checklist