-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merton] Adds parks and open spaces layer #5294
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5294 +/- ##
==========================================
+ Coverage 82.42% 82.44% +0.01%
==========================================
Files 415 415
Lines 32862 32896 +34
Branches 5272 5275 +3
==========================================
+ Hits 27087 27120 +33
Misses 4218 4218
- Partials 1557 1558 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, and thanks for the tests, but I don't think the out-of-boundary park works on .com, there's nothing to set that up to work (sorry if I missed it!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that should do it :)
Just one name change for clarity
79a09e2
to
6472a96
Compare
Layer contains parks that Merton not responsible for: Wimbledon Common, Mitcham Common, Morden Hall Park which have specific stoppers to guide to the right place. Only allowed to make a park report on a park or open space on the layer for responsible parks. Exceptional park Commons Extension Sports Ground is in Kingston, but is responsibility of Merton so can be selected from Merton Cobrand. mysociety/societyworks#4643 https://mysocietysupport.freshdesk.com/a/tickets/3934
952bb11
to
5b9c962
Compare
And Cypress tests
Server config in same branch on servers
[skip changelog]