Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merton] Adds parks and open spaces layer #5294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Dec 6, 2024

[Merton] Adds parks and open spaces layer

Layer contains parks that Merton not responsible for:
Wimbledon Common, Mitcham Common, Morden Hall Park
which have specific stoppers to guide to the right
place.

Only allowed to make a park report on a park or open
space on the layer for responsible parks.

Exceptional park Commons Extension Sports Ground is
in Kingston, but is responsibility of Merton so
can be selected from Merton Cobrand.

And Cypress tests

https://github.com/mysociety/societyworks/issues/4643
https://mysocietysupport.freshdesk.com/a/tickets/3934

Server config in same branch on servers

[skip changelog]

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (6bc48d9) to head (5b9c962).

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Merton.pm 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5294      +/-   ##
==========================================
+ Coverage   82.42%   82.44%   +0.01%     
==========================================
  Files         415      415              
  Lines       32862    32896      +34     
  Branches     5272     5275       +3     
==========================================
+ Hits        27087    27120      +33     
  Misses       4218     4218              
- Partials     1557     1558       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MorayMySoc MorayMySoc requested a review from dracos December 6, 2024 17:09
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, and thanks for the tests, but I don't think the out-of-boundary park works on .com, there's nothing to set that up to work (sorry if I missed it!).

templates/web/merton/report/new/roads_message.html Outdated Show resolved Hide resolved
data/test-asset-layers.yml Outdated Show resolved Hide resolved
.cypress/cypress/integration/merton.js Outdated Show resolved Hide resolved
perllib/FixMyStreet/Cobrand/Merton.pm Outdated Show resolved Hide resolved
@MorayMySoc MorayMySoc requested a review from dracos December 16, 2024 16:40
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that should do it :)
Just one name change for clarity

@mysociety-pusher mysociety-pusher force-pushed the mrt170-park-outside-merton-boundary branch from 79a09e2 to 6472a96 Compare December 17, 2024 15:27
@MorayMySoc MorayMySoc requested a review from dracos December 18, 2024 17:06
Layer contains parks that Merton not responsible for:
Wimbledon Common, Mitcham Common, Morden Hall Park
which have specific stoppers to guide to the right
place.

Only allowed to make a park report on a park or open
space on the layer for responsible parks.

Exceptional park Commons Extension Sports Ground is
in Kingston, but is responsibility of Merton so
can be selected from Merton Cobrand.

mysociety/societyworks#4643
https://mysocietysupport.freshdesk.com/a/tickets/3934
@dracos dracos force-pushed the mrt170-park-outside-merton-boundary branch from 952bb11 to 5b9c962 Compare December 24, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants