[Bexley] Add customised map pins #5275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5275 +/- ##
==========================================
+ Coverage 82.40% 82.65% +0.25%
==========================================
Files 415 415
Lines 32833 33388 +555
Branches 5265 5452 +187
==========================================
+ Hits 27055 27597 +542
+ Misses 4222 4221 -1
- Partials 1556 1570 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Not sure what package was used to change the colours, but it's made them very jaggedy in doing so - compare e.g. https://github.com/mysociety/fixmystreet/blob/dc1ba7b689138aa5a6efa0755d61fe0eeeda244d/web/cobrands/bexley/images/pin-aqua-big.png vs https://github.com/mysociety/fixmystreet/blob/master/web/i/pin-yellow-big.png
So that needs sorting somehow, I'm afraid
| return 'orange' if $p->state eq 'action_scheduled'; | ||
| return 'green' if $p->is_fixed; | ||
| return 'spring' if $p->is_closed; | ||
| return 'grape' if $p->state eq 'not_council_responsibility'; |
There was a problem hiding this comment.
This line will never be reached because it'll match on the is_closed line above.
dracos
force-pushed
the
fd-4521-bexley-icon-colours
branch
from
b5d7376 to
22eb7c8
Compare
This puts them all under web/i/pins, one directory per 'colour', path_to_pin_icons is only used for sourcing shadow/spot files.
dracos
force-pushed
the
fd-4521-bexley-icon-colours
branch
2 times, most recently
from
c2ac201 to
74b5587
Compare
dracos
force-pushed
the
fd-4521-bexley-icon-colours
branch
from
74b5587 to
fa99002
Compare
https://mysocietysupport.freshdesk.com/a/tickets/4521 https://github.com/mysociety/societyworks/issues/4626
[skip changelog]