feat: better transferring #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Okiki <[email protected]>
mys1024
requested changes
Mar 11, 2024
Signed-off-by: Okiki <[email protected]>
|
Sorry, this week was a little busy for me |
|
@okikio No need to be sorry, thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple problems with the way
transferableswork. You currently don't check for runtime support, and neither do you check fortransferablesin complex objects. I'm using @okikio/transferables to cover thetransferablesusecases. Also, for theisTransferablesyou're currently usinggetGlobalVarwhich is a potential security risk as it callsFunction("return ...")if someone passes in custom code, you can potentially have XSS attacks.