🐛 FIX: more bugs

mvc-labs · Sep 25, 2023 · e0a8dea · e0a8dea
1 parent 4b180b1
commit e0a8dea
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/lib/crypto.ts b/src/lib/crypto.ts
@@ -173,14 +173,14 @@ export const signTransactions = async (
     // find out if this transaction depends on previous ones
     // if so, we need to update the prevTxId of the current one
     if (toSign.dependsOn !== undefined) {
-      // structure replace
+      // structure dependencies
       const wrongTxId = tx.inputs[inputIndex].prevTxId.toString('hex')
       const prevTxId = signedTransactions[toSign.dependsOn].txid
 
-      // data replace
+      // data dependencies
       let wrongDataTxId: string
       let prevDataTxId: string
-      if (toSign.dataDependsOn) {
+      if (toSign.dataDependsOn !== undefined) {
         const dataDependentTx = new mvc.Transaction(toSignTransactionsWithDependsOn[toSign.dataDependsOn].txHex)
         wrongDataTxId = dataDependentTx.id
         prevDataTxId = signedTransactions[toSign.dataDependsOn].txid
@@ -189,9 +189,11 @@ export const signTransactions = async (
         prevDataTxId = prevTxId
       }
 
+      // update the prevTxId of the current tx
       tx.inputs[inputIndex].prevTxId = Buffer.from(prevTxId, 'hex')
 
       // if hasMetaId is true, we need to also update the parent txid written in OP_RETURN
+      // based on the wrongDataTxId and prevDataTxId
       if (hasMetaId) {
         const { messages: metaIdMessages, outputIndex } = await parseLocalTransaction(tx)