Update our copy of Opus to fix warnings about not having lrint #23474
+5,688
−2,822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
force-pushed
the
opus_warnings
branch
from
7a4c585
to
897ba99
Compare
They appear in Qt Creator (sometimes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something was apparently off with their CMake files so that
float_cast.hthought thatmath.hisn't present (and spat out an extraordinary amount of warnings about that), but it is present. Replacing our copy of Opus with the one from the .tar.gz attached to their 1.4 release fixes this.(Apparently this problem is not seen in CI logs, but it did occur for me locally, and now it doesn't anymore.)