Enable munin-node-c to build and run on macOS/Darwin #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Would you be awesome by adding corresponding lines to the Note that I'll squash the PR into only 2 commits prior to merge. |
|
Sure, I modified the Travis CI configuration to also build on macOS. |
|
I rewrote most of your commits messages in https://github.com/steveschnepp/munin-c/commits/macos . The code itself wasn't touched. If you get those commits into your PR, I'll happily merge the PR ;-) |
|
OK, I updated the commit messages to match yours, and squashed/dropped the debug commits. The Travis CI build failure seems to be an issue on their end |
|
Yep, restarting the build made it pass. |
|
Great! Thanks. |
|
note, i started to port plugins to BSD, but it ended up being a little more complex than anticipated... |
|
have a look at #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small changes that enable
munin-node-cto build and run on macOS/Darwin. Tested on OS X 10.10, macOS 10.13, and macOS 10.14.(
munin-plugins-cdoesn't work yet, since that relies on/procwhich doesn't exist on macOS. But this PR enablesmunin-node-cto work with other plugins.)