-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sovereign] Fix resync cross chain data integrity checks #6587
base: feat/sovereign-mainchain-header-sync
Are you sure you want to change the base?
[sovereign] Fix resync cross chain data integrity checks #6587
Conversation
…-resync-cross-chain-data
…-resync-cross-chain-data
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/sovereign-mainchain-header-sync #6587 +/- ##
========================================================================
- Coverage 77.65% 77.64% -0.02%
========================================================================
Files 953 957 +4
Lines 108816 108879 +63
========================================================================
+ Hits 84497 84534 +37
- Misses 18499 18524 +25
- Partials 5820 5821 +1 ☔ View full report in Codecov by Sentry. |
@@ -4,6 +4,7 @@ import ( | |||
"errors" | |||
"testing" | |||
|
|||
"github.com/multiversx/mx-chain-core-go/core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your imports format is broken in Golang
Reasoning behind the pull request
Proposed changes
checkMiniBlocksHeaders
&CheckValidity
to acceptcore.MainChainShardID
as valid shard IDTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?