Update column.py closes #63 #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multimeric
reviewed
Aug 28, 2021
| return [error for validation in self.validations for error in validation.get_errors(series, self)] | ||
|
|
||
| # skip validation if column contains no validation objects. Used for columns that require no validation but must be present in DataFrame | ||
| if self.validations == []: |
There was a problem hiding this comment.
More Pythonic to say if not self.validations
multimeric
requested changes
Aug 28, 2021
There was a problem hiding this comment.
Firstly, we need to wait for you to work out the underlying issue in #63.
Secondly, we need a test for this please.
|
Can you please release this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.