Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of Skein #52

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

DonaldTsang
Copy link

@DonaldTsang DonaldTsang commented May 10, 2017

As a new add-on for Multihash (see multiformats/multihash#83
and multiformats/multihash#82)
I have added some Go code to the files to comply with the new proposed standard.
I know only a minimal amount of Go, hope someone can correct me.

@DonaldTsang
Copy link
Author

DonaldTsang commented May 10, 2017

What are these codecov tests?

@Kubuxu
Copy link
Member

Kubuxu commented May 11, 2017

They are testing for code coverage. Your new functions are not covered by tests.

@DonaldTsang
Copy link
Author

@Kubuxu All the tests in Travis has passed, yet the tests in codecov is not?
What can I do about it? Could you supervise me if you can?

@DonaldTsang
Copy link
Author

@Kubuxu I give up on Go. If you can find someone who can patch it, and fix the Hash code for BLAKE2 and Skein, that would be great. 😭

@DonaldTsang
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants