Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Move HighlightedCode test into @mui/docs package #42835

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[code-infra] Move HighlightedCode test into @mui/docs package #42835

merged 1 commit into from
Jul 3, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 3, 2024

Follow-up on #42833.

  • Move the HighlightedCode test beside the HighlightedCode component into the @mui/docs package
    • Update the types array in the docs package to make TS happy on other tests

@LukasTy LukasTy added the scope: code-infra Specific to the core-infra product label Jul 3, 2024
@LukasTy LukasTy requested review from Janpot and a team July 3, 2024 15:01
@LukasTy LukasTy self-assigned this Jul 3, 2024
@mui-bot
Copy link

mui-bot commented Jul 3, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42835--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9715c1b

Janpot
Janpot approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this also partly covers https://github.com/mui/material-ui/pull/42060/files#diff-d64432e2abe60e960bde74bc678685d239eab7c208add373c88ed934ed1e6ba9

@LukasTy LukasTy merged commit 91aee6e into mui:next Jul 3, 2024
23 checks passed
@LukasTy LukasTy deleted the move-highlighted-code-test branch July 3, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

@LukasTy LukasTy

Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasTy @mui-bot @Janpot