Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Buffer -> Uint8Array #488

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

joscha
Copy link
Contributor

@joscha joscha commented Oct 17, 2024

Via:

          > is it safe to assume that all occurrences of Buffer should become Uint8Array

Yes.

Originally posted by @mtth in #452 (comment)

@mtth mtth merged commit be5a1b3 into mtth:master Oct 19, 2024
3 checks passed
@joscha joscha deleted the joscha/ts-buffer-to-uint8 branch October 19, 2024 17:46
@joscha
Copy link
Contributor Author

joscha commented Oct 19, 2024

@mtth would you mind pushing a new 6.x with this change, please?

@mtth
Copy link
Owner

mtth commented Oct 20, 2024

@joscha - 6.0.0-alpha.15

@joscha
Copy link
Contributor Author

joscha commented Oct 20, 2024

Thank you!

@joscha
Copy link
Contributor Author

joscha commented Oct 23, 2024

We could catch issues like these by introducing https://github.com/tsdjs/tsd into this repository until such time that a conversion to TS (see #479) is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants