Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msmtp: update to 1.8.27 #22699

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

msmtp: update to 1.8.27 #22699

wants to merge 3 commits into from

Conversation

raedrizqie
Copy link
Contributor

@raedrizqie raedrizqie commented Nov 30, 2024

Fixes #22187
Fixes #22357

  • fix config file dir
  • fix socket
  • update dependencies
$ msmtp --version
msmtp version 1.8.27
Platform: x86_64-w64-mingw32
TLS/SSL library: GnuTLS
Authentication library: GNU SASL; oauthbearer and xoauth2: built-in
Supported authentication methods:
scram-sha-256-plus scram-sha-1-plus scram-sha-256 scram-sha-1 plain gssapi external oauthbearer cram-md5 digest-md5 login ntlm xoauth2
IDN support: enabled
NLS: enabled, LOCALEDIR is C:\MSYS64\ucrt64\bin\..\share\locale
Keyring support: Gnome
System configuration file name: C:\MSYS64\ucrt64\bin\..\etc\msmtprc
User configuration file name: C:\MSYS64\home\raed\.msmtprc

Copyright (C) 2024 Martin Lambers and others.
This is free software.  You may redistribute copies of it under the terms of
the GNU General Public License <http://www.gnu.org/licenses/gpl.html>.
There is NO WARRANTY, to the extent permitted by law.

$ echo -e "Subject: Testing" | msmtp --debug -t [email protected]
loaded system configuration file C:\MSYS64\ucrt64\bin\..\etc\msmtprc
ignoring user configuration file C:\MSYS64\home\raed\.msmtprc: No such file or directory
falling back to default account
using account default from C:\MSYS64\ucrt64\bin\..\etc\msmtprc
host = 127.0.0.1
port = 7659
source ip = (not set)
proxy host = (not set)
proxy port = 0
socket = (not set)
timeout = off
protocol = smtp
domain = localhost
auth = PLAIN
user = test
password = *
passwordeval = (not set)
ntlmdomain = (not set)
tls = off
tls_starttls = off
tls_trust_file = system
tls_crl_file = (not set)
tls_fingerprint = (not set)
tls_key_file = (not set)
tls_cert_file = (not set)
tls_certcheck = on
tls_min_dh_prime_bits = (not set)
tls_priorities = (not set)
tls_host_override = (not set)
auto_from = off
maildomain = (not set)
from = [email protected]
from_full_name = (not set)
allow_from_override = on
set_from_header = auto
set_date_header = auto
remove_bcc_headers = on
undisclosed_recipients = off
dsn_notify = (not set)
dsn_return = (not set)
logfile = (not set)
logfile_time_format = (not set)
syslog = (not set)
aliases = (not set)
reading recipients from the command line and the mail
msmtp.exe: cannot connect to 127.0.0.1, port 7659: connection refused
msmtp.exe: could not send mail (account default from C:\MSYS64\ucrt64\bin\..\etc\msmtprc)

mingw-w64-msmtp/PKGBUILD Outdated Show resolved Hide resolved
mingw-w64-msmtp/002-net-socket-fix.patch Outdated Show resolved Hide resolved
mingw-w64-msmtp/002-net-socket-fix.patch Outdated Show resolved Hide resolved
#ifdef ENABLE_NLS
printf(_("enabled"));
- printf(_(", LOCALEDIR is %s"), LOCALEDIR);
+ char *localedir = get_filename(getenv("MINGW_PREFIX"), "share/locale");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means it will crash when being run outside of MSYS2, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.. but I dont know a better way so that the path won't be translated into CI's prefix

Copy link
Member

@lazka lazka Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, the hack is better than nothing, but it is should handle getenv() returning NULL and not just crash.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better approach to see where launched executable is and build a path from there (../share/local)? I would like to see it work when called from outside of MSYS2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.. please test the from the artifacts (when it finished building)

mingw-w64-msmtp/001-config-file-location.patch Outdated Show resolved Hide resolved
mingw-w64-msmtp/001-config-file-location.patch Outdated Show resolved Hide resolved
mingw-w64-msmtp/001-config-file-location.patch Outdated Show resolved Hide resolved
- fix config file dir
- fix socket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[msmtp] msmtp.exe: account default not found: no configuration file available [msmtp] Incorrect LOCALEDIR
3 participants