-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msmtp: update to 1.8.27 #22699
base: master
Are you sure you want to change the base?
msmtp: update to 1.8.27 #22699
Conversation
#ifdef ENABLE_NLS | ||
printf(_("enabled")); | ||
- printf(_(", LOCALEDIR is %s"), LOCALEDIR); | ||
+ char *localedir = get_filename(getenv("MINGW_PREFIX"), "share/locale"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means it will crash when being run outside of MSYS2, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.. but I dont know a better way so that the path won't be translated into CI's prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, the hack is better than nothing, but it is should handle getenv() returning NULL and not just crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better approach to see where launched executable is and build a path from there (../share/local
)? I would like to see it work when called from outside of MSYS2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.. please test the from the artifacts (when it finished building)
4182af6
to
4e28076
Compare
- fix config file dir - fix socket
Fixes #22187
Fixes #22357