Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw-w64: disable wildcard by default #22263

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

lazka
Copy link
Member

@lazka lazka commented Oct 22, 2024

No description provided.

@lazka
Copy link
Member Author

lazka commented Oct 29, 2024

Some docs: msys2/msys2.github.io#347

@lazka lazka force-pushed the mingw-w64-disable-wildcard branch from eff86a2 to 2f5cd52 Compare November 2, 2024 16:49
@lazka lazka marked this pull request as ready for review November 2, 2024 16:49
@lazka
Copy link
Member Author

lazka commented Nov 2, 2024

news entry: msys2/msys2.github.io#348

lazka added a commit to lazka/MSYS2-packages that referenced this pull request Nov 2, 2024
@mati865
Copy link
Collaborator

mati865 commented Nov 2, 2024

IIRC this will break Rust build or Rust testsuite on envs using Binutils or at least this was the case last year.

lazka added a commit to msys2/MSYS2-packages that referenced this pull request Nov 3, 2024
@lazka
Copy link
Member Author

lazka commented Nov 3, 2024

Thanks. Did someone try this last year?

If all fails we can re-enable it on a per-package basis.

@mati865
Copy link
Collaborator

mati865 commented Nov 3, 2024

I was able to find the old error: C:/a/rust/rust/i686-w64-mingw32/bin/../lib/gcc/i686-w64-mingw32/13.2.0/../../../../i686-w64-mingw32/bin/ld.exe: cannot find C:\a\rust\rust\build\i686-pc-windows-gnu\stage2\lib\rustlib\i686-pc-windows-gnu\lib/liballoc-*.rlib: Invalid argument.

It was previously called from Makefile: https://github.com/rust-lang/rust/pull/128407/files#diff-53c7f7d0d39446b7fbe61af298fbdbdcdfcd1a7f083095343edc545a8926c6f6L14
Since it's rewritten in Rust, this won't fail anymore, but there might be other places (also in different packages) where the toolchain is expected to handle globs, just like on Linux.

@lazka
Copy link
Member Author

lazka commented Nov 3, 2024

Thanks, from what I understand enabling wildcards in gcc would also fix this case? https://github.com/gcc-mirror/gcc/blob/7f67acf60c5429895d7c9e5df81796753e2913e0/gcc/configure.ac#L2263

@mati865
Copy link
Collaborator

mati865 commented Nov 3, 2024

Sounds likely but won't work for Binutils tools that don't go through GCC like when calling ar, but that might be an uncommon thing to do.

@lazka lazka merged commit 21ee9d0 into msys2:master Nov 3, 2024
8 checks passed
@lazka
Copy link
Member Author

lazka commented Nov 3, 2024

let's see :)

lazka added a commit to lazka/msys2-tests that referenced this pull request Nov 3, 2024
stahta01 pushed a commit to stahta01/MSYS2-cygwin-packages that referenced this pull request Dec 21, 2024
stahta01 pushed a commit to stahta01/MSYS2-cygwin-packages that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants