-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update angular project #121
base: main
Are you sure you want to change the base?
Conversation
Hi, @jstnjs. Thanks for opening this! Can you tell me more what these changes pursue? |
Hi, I just realised something is still going wrong in the editor. I'll post an update somewhere this week with an overview of the changes I did. |
Hey @kettanaito I took a stab at fixing the issue you pointed out in the file. There are some strange behaviors at play. When you set up a clean Angular app and add Jest, everything works fine. But as soon as you add Cypress, the types in the editor start breaking (even though the tests run successfully). For instance, the editor throws this error: To resolve this, I excluded That seemed to fix it... or so I thought. I created a custom After inspecting the Another challenge: tests pass in the editor, but fail when running
It appears this is due to the unavailability of the fetch API in jsdom (related issues: #930, #7007, and #13834). As per the MSW documentation, I added the Summary of updates:
If you have any questions about specific details, let me know! |
I'm writing a article on MSW with Angular and just noticed something. The service worker script was included in the production bundle. I changed the config to include the script only in development. |
Hi,
I like the project and always wanted to try update a plain angular project. Feel free to decline :)