-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beautify the generated code and add type #103
base: master
Are you sure you want to change the base?
Conversation
Changes Unknown when pulling d9f3d91 on putaolabs:master into ** on msoucy:master**. |
message Person { | ||
required string name = 1; | ||
required string name = 1; // namnmknhi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
@@ -43,27 +113,28 @@ struct MessageType { | |||
EnumType[] enumTypes; | |||
MessageType[] messageTypes; | |||
|
|||
const void toString(scope void delegate(const(char)[]) sink, FormatSpec!char fmt) | |||
const void toString(scope void delegate(const(char)[]) sink, ref ProtoConfig fmt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer compliant with the required spec for toString
int rpc = 1; | ||
} | ||
|
||
struct ProtoPackage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this moved?
Beautify the generated code
add option to dprotoc to generated code