More options for file uploads

[martin67]

Add possibility to set custom title and/or description of the uploaded file.

[mschilli]

Can you also add it to the POD docs, and provide an example so people know how to use it, please?

[martin67]

Ok, I'll update that as well.

Regards
//Martin

2014-11-20 9:17 GMT+01:00 Mike Schilli [email protected]:

Can you also add it to the POD docs, and provide an example so people know
how to use it, please?

—
Reply to this email directly or view it on GitHub
#8 (comment)
.

[atoomic]

this looks good, but still need some POD update and basic usage so people can start using this feature. @martin67 are you still interested to add some doc/examples?

[atoomic]

@martin67 just checking if you are still interested adding the POD for this new feature?
thanks

[NetworkNed]

With the addition of the rename method, the title option is scarcely necessary - I wouldn't have needed to write the rename method had this been available.

Using this code you can do:

  $drive_id = $gd->file_upload ( "/path/to/file" , $parent, $drive_id, "New Name" ) ;

The rename method was not available when @martin67 submitted this code, but now you can do the same thing with:

  $drive_id = $gd->file_upload ( "/path/to/file" , $parent, $drive_id ) ;
  $gd->rename (  $drive_id, "New Name" ) ;

I'd be inclined to add a $gd->description method rather than these options.

[atoomic]

@NetworkNed description method could be useful, feel free to submit a PR with it
thanks

[atoomic]

Hi @NetworkNed I would like to know if you could rebase your branch and provide some POD for it?
thanks

[NetworkNed]

This isn't my branch. Were you thinking of @martin67?

My contributions were completed with 514b2e8 and 763baeb

With my comment above I intended to express that I think this pull request is obsolete and can be closed.

[atoomic]

oops sorry @NetworkNed I went too fast on it and was thinking you were the original author.
You are right I was mainly asking @martin67 if he has any interest in rebasing this Pull Request with some docs?

[atoomic]

description should be optional too
defined $opts->{ description } ? ( description => $opts->{ description } ) : ()

[atoomic]

please make description optional and add some pod to advertise these new options

[atoomic]

@martin67 I can notice that this PR was waiting for some extra work from your side
Would you be interested in rebasing it and submitting it so we can get it in?
thanks