Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Content-MD5 to multipart header handling #181

Closed
wants to merge 0 commits into from

Conversation

deathgrindfreak
Copy link

Hola gents, I've added some handling for an optional user-generated Content-MD5 header for the multipart type. I'd sure appreciate if we can handle this in a future release, since this would greatly improve my ability to verify the integrity of file uploads.

I brought this up in the issue here, but never heard anything back, so I thought I'd just go ahead and make the change.

@mscdex
Copy link
Owner

mscdex commented Oct 15, 2018

To be honest, if we're going to add support for any additional headers at the busboy layer (you can still use dicer directly currently if you need to access custom headers), I would much rather just provide a way to access any/all headers.

@deathgrindfreak
Copy link
Author

That's kind of the approach I was thinking of taking as well. Would you be down for an optional record type as the last parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants