update config.py and main.py #386
Conversation
Reviewer's Guide by SourceryThis pull request updates the get_order method in main.py to handle cases where the order returned by a client is None. The implementation now checks if the order is not None before returning it. Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mraniki - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -208,4 +208,6 @@ async def get_order( | |||
|
|
|||
| """ | |||
| for client in self.clients: | |||
| return await client.get_order(message) | |||
| order = await client.get_order(message) | |||
There was a problem hiding this comment.
issue (bug_risk): Potential issue with returning the first non-null order
The current implementation returns the first non-null order found. If there are multiple clients and the order from the first client is incomplete or incorrect, this could lead to issues. Consider whether additional validation or checks are needed before returning the order.
| @@ -208,4 +208,6 @@ async def get_order( | |||
|
|
|||
| """ | |||
| for client in self.clients: | |||
| return await client.get_order(message) | |||
| order = await client.get_order(message) | |||
| if order: | |||
There was a problem hiding this comment.
suggestion: Clarify the condition for 'if order'
The condition 'if order' checks for a truthy value. Ensure that this condition is sufficient for your use case. If 'order' can be an empty object or have other falsy values that should still be considered valid, you might need a more specific check.
| if order: | |
| if order is not None and order != {}: |
Summary by Sourcery
This pull request addresses a bug in the get_order function in main.py, ensuring that the function correctly returns an order if found by any client.