Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctrl + C does nothing when using firefox-android without auto-reload or during activity start #2523

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

luskaner
Copy link

@luskaner luskaner commented Oct 10, 2022

Ctrl + C does nothing when using firefox-android in either of these two cases:

  • Automatic reloading is disabled.
  • Waiting to launch the activity on Android. For example: this occurs indefinitely when my device when it is locked.

Fixes #1699

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (ca73b70) to head (7dd22e7).
Report is 472 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2523   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files          32       32           
  Lines        1697     1720   +23     
=======================================
+ Hits         1690     1713   +23     
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luskaner luskaner changed the title Ctrl + C does nothing when using firefox-android fix: ctrl + C does nothing when using firefox-android without auto-reload or during activity start Oct 10, 2022
@luskaner luskaner marked this pull request as ready for review October 10, 2022 18:29
@luskaner
Copy link
Author

luskaner commented Oct 10, 2022

I think the PR is ready for review (I changed the title for the step npm run github-pr-title-lint of the ci/circleci: build-nosejs-current pipeline but does not update)

@willdurand willdurand self-requested a review October 12, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl + C does nothing when using firefox-android
1 participant