Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari 12 workaround for array.reverse caching #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Safari 12 workaround for array.reverse caching #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/vtt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,11 @@
// video, depending on the writing direction, and reverse our axis directions.
if (linePos < 0) {
position += cue.vertical === "" ? containerBox.height : containerBox.width;
axis = axis.reverse();

// Safari 12 introduced a bug where the reverse order of an array is cached after calling
// array.prototype.reverse (https://bugs.webkit.org/show_bug.cgi?id=188794).
// As a workaround, call reverse on a copy of the 'axis' array, instead of calling it directly on the original var
axis = axis.slice().reverse();
}

// Move the box to the specified position. This may not be its best
Expand Down