Fix: handle stack frames in the correct order #1762
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f3c64ee removed
ObjArray
and replaced its usage with standard JDK classes. InInterpreter
, in particular, anArrayDeque
is now used to storecx.previousInterpreterInvocations
, which is used to generate the stack frame information. However, there is one place wheretoArray
is done, and the behavior forObjArray
andArrayDeque
are different (swapped).Unfortunately no tests actually ends up exercising this difference due to the interpreter function peeling optimization done in #1510.
We have discovered this problem because, in ServiceNow's fork, we currently need to disable the function peeling optimization.
I cannot figure out how to write an unit test for this problem, though. Any ideas?
To verify that the behavior are different, I've written this code:
It prints: