Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to the pre-Java-9 stack trace API #1761

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

gbrail
Copy link
Collaborator

@gbrail gbrail commented Dec 18, 2024

Go back to "new Throwable()" to create a stack trace. This had been updated in a previous PR. However, these APIs were not Android-compatible, and also they caused a strange performance regression in Test262SuiteTest.

Fixes #1680

This is compatible with Android and also seems to be faster
@gbrail gbrail merged commit b40416f into mozilla:master Dec 19, 2024
3 checks passed
@gbrail gbrail deleted the greg-fix-stack-api branch December 19, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getSourcePositionFromJavaStack cannot perform well on Android system
1 participant