Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "testutils" module and move common test code there #1760

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

gbrail
Copy link
Collaborator

@gbrail gbrail commented Dec 18, 2024

This adds a "testutils" module that contains code that may be used by all of the Rhino tests. Currently it contains the "Utils" class which is used by both the "rhino" and "tests" modules, but it could contain more.

In order for this to work, code in the module is kept in the "src/main/java" directory so that other modules can depend on it for testing purposes, even though none of the code in this module should ever be used outside tests.

@gbrail gbrail mentioned this pull request Dec 18, 2024
@rbri
Copy link
Collaborator

rbri commented Dec 18, 2024

@gbrail thanks

@gbrail gbrail merged commit 5da136c into mozilla:master Dec 19, 2024
3 checks passed
@gbrail gbrail deleted the add-test-utils branch December 19, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants