Add nullable JS API parameter support

[drubanovich-soti]

This change allows to define JS APIs which receive nullable primitive type parameters. E.g. before the change it was not possible to pass null to JS function with string parameter, instead the function received a string "null".

As standard Java doesn't have nullable types, this feature currently can only be used if the files are written in Kotlin. Kotlin metadata library is used to detect nullable parameter types.

[drubanovich-soti]

I would like to run this idea with you before I fix the module (it doesn't export Kotlin dependencies, so the clients will need to explicitly add those) and add unit tests.
Thanks!

[gbrail]

Thanks for working on this! This is an interesting idea, and it'd be great to have Rhino work better with Kotlin.

However, right now Rhino has no dependencies, and I think it's important that we keep it that way. This PR makes Rhino depend on a Kotlin package. I don't know how intrusive that is (like how many nested dependencies it brings in) but I'm still very reluctant to make a core library like this something that Rhino requires.

Is there another way to do this, like making the dependency optional and searching for it via reflection, or adding a "rhino-kotlin" module that's loaded via ServiceLoader, or incorporating the part of the Kotlin library that Rhino needs in to the project directly?

[drubanovich-soti]

Sure Greg, if you like the idea, I will work on a proper implementation.
I'll try your ServiceLoader suggestion with Kotlin-specific implementation in a new "rhino-kotlin" module.

[gbrail]

One idea might be to add a new module, like "rhino-kotlin", that Kotlin users can add... Just one of many possible ideas. I'm hoping that we can release a "1.8.0" soon and this might not make it in that release, but we can get to it soon after!

…

On Sat, Dec 14, 2024 at 7:57 AM drubanovich-soti ***@***.***> wrote: Sure Greg, if you like the idea, I will work on a proper implementation. I'll try your ServiceLoader suggestion with Kotlin-specific implementation in a new "rhino-kotlin" module. — Reply to this email directly, view it on GitHub <#1756 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD7I27Y4BMEMIS4HEERPFT2FRIO5AVCNFSM6AAAAABTSNARF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTGE3DKNBUHE> . You are receiving this because you commented.Message ID: ***@***.***>