fix tokenEnd and cursor for string, template, xml literals and comments when using multibyte characters #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiline comments when using multibyte characters
rbri
reviewed
Dec 2, 2024
| @@ -1208,6 +1212,41 @@ public void testParseUnicodeMultibyteCharacter() { | |||
| AstNode first = ((ExpressionStatement) root.getFirstChild()).getExpression(); | |||
| assertEquals("𠮷", first.getString()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testParseMultibyteCharacter_StringLiteral() { | |||
There was a problem hiding this comment.
there is no need to start the method name with 'test' as we have the annotation. Can you please change the names to use the same pattern as for the other test (in this file)
There was a problem hiding this comment.
I changed the names, but 2 unit tests which were already there started with "test" (changed those as well)
|
@meraedit many thanks for this contribution. The spotless checks are failing because of some format violations. Please run './gradlew :tests:spotlessApply' to fix these violations |
|
Sorry @meraedit, still some spotless failures |
|
Thanks! I agree with @rbri 's comments, which you addressed, so thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multibyte characters, the tokenEnd and cursor need to be adjusted otherwise the length of string, template, xml literals and comments is not correct.