Optimize performance in test262 #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NativeJavaListTest > length FAILED RegexpTest > unsupportedFlagCtor FAILED |
rPraml
force-pushed
the
performance-test262
branch
from
bc214e4 to
dafed6d
Compare
|
Fixed the condition in the "filter"method. Now ShellTimerTest fails. Waiting for #1672, then I'll do a rebase |
Improves the startup time from about 3 sec to < 1 sec
rPraml
force-pushed
the
performance-test262
branch
from
dafed6d to
3b41680
Compare
rPraml
commented
Oct 4, 2024
| /** Returns the current filename in the java stack. */ | ||
| @SuppressWarnings("AndroidJdkLibsChecker") | ||
| // Android uses interpreter, so we should not get here. | ||
| static String getSourcePositionFromJavaStack(int[] linep) { |
There was a problem hiding this comment.
Rebase is done. Maybe someone can confirm, that android always uses interpreter, so we should not get here ;)
|
@rPraml thanks for that, faster tests are always a good thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets two issues I found with a profiler, while running the 262 test suite:
addTestFileshas a nested loop with a complexity of O(n^2). I've replaced this with a hashmap, that improves startup time from ~3 sec down to <1 sec