Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rhino-engine an osgi bundle #1278

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

make rhino-engine an osgi bundle #1278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,11 @@ task engineJar(type: Jar) {
"Implementation-Vendor": "Mozilla Foundation",
"Implementation-URL": "http://www.mozilla.org/rhino",
"Automatic-Module-Name": "org.mozilla.rhino.engine"
"Bundle-ManifestVersion": "2",
"Bundle-SymbolicName": "org.mozilla.rhino.engine",
"Bundle-Version": project.version.replaceAll("-.*", ""),
"Export-Package": "org.mozilla.javascript.engine",
"Import-Package": "javax.script,org.mozilla.javascript"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not declare an Import-Package, and instead leave the default (automatic) behaviour.

Copy link
Author

@stbischof stbischof Nov 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an OSGi import.(has nothing to do with the Automatic-Module-Name) If you do not declare it the bundle will not work/ throw an ClassNotFoundExcaption because bundle does not declare that is needs it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. I do not use OSGi myself, however from https://bnd.bndtools.org/heads/import_package.html:

The Import-Package header lists the packages that are required by the contained packages. The default for this header is *, resulting in importing all referred packages. This header therefore rarely has to be specified.

Copy link
Author

@stbischof stbischof Nov 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. bnd is a tool that calculates die imports. if you say to bnd do * then it will habe as result in the manifest:

Import-Package javax.script,org.mozilla.javascript

but since yopu do not use a tool loke bnd you have to write it by yourown

@juergen-albert (OSGi Working Group Steering Committee)

could you please review this from the OSGi point of view?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @stbischof wrote is correct. bnd is a build tool, that can calculate the Imports for you with proper Version ranges. The same goes for the Export Packages. OSGi requires all the packages to be named separately and can not interpret the *.

bnd even has a dedicated gradle plugin that can automatically calculate a Manifest for your, not only putting in proper OSGi Headers, but can also automatically handle things in respect to Java Module System.

I'm not that firm with gradle, but you can find an example of the gradle plugin usage here: https://github.com/osgi/osgi-test/tree/main/examples/osgi-test-example-gradle

)
}
}
Expand Down