convert RegEx properties #1183

rbri · 2022-02-15T08:20:38Z

Implements the Regex part of #963

src/org/mozilla/javascript/regexp/NativeRegExp.java

tuchida · 2022-02-15T11:19:51Z

src/org/mozilla/javascript/regexp/NativeRegExp.java

@@ -109,6 +109,12 @@

    private static final int ANCHOR_BOL = -2;

+    private static final SymbolKey GET_FLAGS = new SymbolKey("[Symbol.getFlags]");


Is this a Symbol? Symbol is written as [ @@match ].
https://262.ecma-international.org/12.0/#sec-get-regexp.prototype.flags

tuchida · 2022-02-15T11:25:53Z

src/org/mozilla/javascript/regexp/NativeRegExp.java

@@ -126,6 +132,36 @@ public static void init(Context cx, Scriptable scope, boolean sealed) {

        ctor.setImmunePrototypeProperty(proto);

+        ScriptableObject desc = (ScriptableObject) cx.newObject(scope);


(I don't know much about this area, but...) Could you write simply using Lambda?

rhino/src/org/mozilla/javascript/NativePromise.java

Lines 41 to 76 in ae78dbf

constructor.defineConstructorMethod(

scope, "resolve", 1, NativePromise::resolve, DONTENUM, DONTENUM | READONLY);

constructor.defineConstructorMethod(

scope, "reject", 1, NativePromise::reject, DONTENUM, DONTENUM | READONLY);

constructor.defineConstructorMethod(

scope, "all", 1, NativePromise::all, DONTENUM, DONTENUM | READONLY);

constructor.defineConstructorMethod(

scope, "allSettled", 1, NativePromise::allSettled, DONTENUM, DONTENUM | READONLY);

constructor.defineConstructorMethod(

scope, "race", 1, NativePromise::race, DONTENUM, DONTENUM | READONLY);

ScriptableObject speciesDescriptor = (ScriptableObject) cx.newObject(scope);

ScriptableObject.putProperty(speciesDescriptor, "enumerable", false);

ScriptableObject.putProperty(speciesDescriptor, "configurable", true);

ScriptableObject.putProperty(

speciesDescriptor,

"get",

new LambdaFunction(

scope,

"get [Symbol.species]",

0,

(Context lcx, Scriptable lscope, Scriptable thisObj, Object[] args) ->

constructor));

constructor.defineOwnProperty(cx, SymbolKey.SPECIES, speciesDescriptor, false);

constructor.definePrototypeMethod(

scope,

"then",

2,

(Context lcx, Scriptable lscope, Scriptable thisObj, Object[] args) -> {

NativePromise self =

LambdaConstructor.convertThisObject(thisObj, NativePromise.class);

return self.then(lcx, lscope, constructor, args);

},

DONTENUM,

DONTENUM | READONLY);

Will check.....

p-bakker · 2022-02-15T11:26:43Z

testsrc/test262.properties

    prototype/multiline/this-val-regexp-prototype.js
    prototype/source/cross-realm.js {unsupported: [cross-realm]}
-    prototype/source/length.js
-    prototype/source/name.js
    prototype/source/prop-desc.js


Any idea why this one doesn't pass yet?

Strange will have a look

rbri · 2022-02-17T19:20:24Z

This symbol seem to be too hacky, but the id scriptable object is a nightmare for this kind of properties. I have to digg deeper into the mud here. - will require some more days.

p-bakker · 2022-03-02T11:29:59Z

@rbri just wondering how this PR is coming along, as I'm working on implementing the unicode flag and while analysing failing tests related to the unicode property, some are due me currently having added the unicode property as a data property instead of an accessor property

p-bakker · 2022-03-02T11:34:21Z

testsrc/test262.properties

    prototype/source/prop-desc.js
    prototype/source/this-val-regexp-prototype.js
    prototype/source/value-empty.js
    prototype/source/value-line-terminator.js
    prototype/source/value-u.js
    prototype/sticky/cross-realm.js {unsupported: [cross-realm]}
-    prototype/sticky/length.js
-    prototype/sticky/name.js
-    prototype/sticky/prop-desc.js
    prototype/sticky/this-val-regexp-prototype.js


This test is dependant on the sticky property being implemented as an accessor property. However, it looks like your changes haven't caused it to pass yet.

Not sure if that is due to the accessor property impl or if something else, possibly unrelated, is going on

p-bakker · 2022-04-13T17:16:11Z

@rbri just wondering how this PR is coming along

p-bakker · 2024-08-12T05:40:33Z

@rbri any chance for a quick update on this one?

Is getting these types of properties properly implemented in IdScriptables maybe dead in the water completely and we should look at converting relevant implementations into lambda's instead?

convert RegEx properties

ae78dbf

p-bakker reviewed Feb 15, 2022

View reviewed changes

src/org/mozilla/javascript/regexp/NativeRegExp.java Show resolved Hide resolved

src/org/mozilla/javascript/regexp/NativeRegExp.java Show resolved Hide resolved

add souce getter

fe01038

tuchida reviewed Feb 15, 2022

View reviewed changes

p-bakker reviewed Feb 15, 2022

View reviewed changes

p-bakker reviewed Mar 2, 2022

View reviewed changes

p-bakker added this to the Release 1.7.15 milestone Apr 14, 2022

p-bakker mentioned this pull request Aug 8, 2023

Support ES2015 Proxies & Reflect API #268

Closed

p-bakker removed this from the Release 1.7.15 milestone May 21, 2024

camnwalter mentioned this pull request Aug 13, 2024

Add ES2019 Symbol.prototype.description #1561

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

convert RegEx properties #1183

convert RegEx properties #1183

rbri commented Feb 15, 2022 •

edited by p-bakker

Loading

tuchida Feb 15, 2022

tuchida Feb 15, 2022

rbri Feb 15, 2022

p-bakker Feb 15, 2022

rbri Feb 15, 2022

rbri commented Feb 17, 2022

p-bakker commented Mar 2, 2022 •

edited

Loading

p-bakker Mar 2, 2022

p-bakker commented Apr 13, 2022

p-bakker commented Aug 12, 2024

		@@ -109,6 +109,12 @@

		private static final int ANCHOR_BOL = -2;

		private static final SymbolKey GET_FLAGS = new SymbolKey("[Symbol.getFlags]");

		@@ -126,6 +132,36 @@ public static void init(Context cx, Scriptable scope, boolean sealed) {

		ctor.setImmunePrototypeProperty(proto);

		ScriptableObject desc = (ScriptableObject) cx.newObject(scope);

	constructor.defineConstructorMethod(
	scope, "resolve", 1, NativePromise::resolve, DONTENUM, DONTENUM \| READONLY);
	constructor.defineConstructorMethod(
	scope, "reject", 1, NativePromise::reject, DONTENUM, DONTENUM \| READONLY);
	constructor.defineConstructorMethod(
	scope, "all", 1, NativePromise::all, DONTENUM, DONTENUM \| READONLY);
	constructor.defineConstructorMethod(
	scope, "allSettled", 1, NativePromise::allSettled, DONTENUM, DONTENUM \| READONLY);
	constructor.defineConstructorMethod(
	scope, "race", 1, NativePromise::race, DONTENUM, DONTENUM \| READONLY);

	ScriptableObject speciesDescriptor = (ScriptableObject) cx.newObject(scope);
	ScriptableObject.putProperty(speciesDescriptor, "enumerable", false);
	ScriptableObject.putProperty(speciesDescriptor, "configurable", true);
	ScriptableObject.putProperty(
	speciesDescriptor,
	"get",
	new LambdaFunction(
	scope,
	"get [Symbol.species]",
	0,
	(Context lcx, Scriptable lscope, Scriptable thisObj, Object[] args) ->
	constructor));
	constructor.defineOwnProperty(cx, SymbolKey.SPECIES, speciesDescriptor, false);

	constructor.definePrototypeMethod(
	scope,
	"then",
	2,
	(Context lcx, Scriptable lscope, Scriptable thisObj, Object[] args) -> {
	NativePromise self =
	LambdaConstructor.convertThisObject(thisObj, NativePromise.class);
	return self.then(lcx, lscope, constructor, args);
	},
	DONTENUM,
	DONTENUM \| READONLY);

convert RegEx properties #1183

Are you sure you want to change the base?

convert RegEx properties #1183

Conversation

rbri commented Feb 15, 2022 • edited by p-bakker Loading

tuchida Feb 15, 2022

Choose a reason for hiding this comment

tuchida Feb 15, 2022

Choose a reason for hiding this comment

rbri Feb 15, 2022

Choose a reason for hiding this comment

p-bakker Feb 15, 2022

Choose a reason for hiding this comment

rbri Feb 15, 2022

Choose a reason for hiding this comment

rbri commented Feb 17, 2022

p-bakker commented Mar 2, 2022 • edited Loading

p-bakker Mar 2, 2022

Choose a reason for hiding this comment

p-bakker commented Apr 13, 2022

p-bakker commented Aug 12, 2024

rbri commented Feb 15, 2022 •

edited by p-bakker

Loading

p-bakker commented Mar 2, 2022 •

edited

Loading