This repository has been archived by the owner on Sep 19, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if you muted the mic via
enableMicrophone(false)
and then calledsetLocalMediaStream(stream)
to say add a video track, the track replacement code re-enabled all the streams effectively unmuting you. I wasn't sure of the reason we previously were settingsender.track.enabled = true
here, so perhaps this introduces a new issue, but the idea is to ensure that if the previous track was disabled we maintain that state when replacing it with a new track.