Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page load for proxied containers when Mozilla VPN isn't active (fix #2570) #2645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lusimeon
Copy link

@lusimeon lusimeon commented Jun 20, 2024

Before submitting your pull request

  • I agree to license my code under the MPL 2.0 license.
  • I rebased my work on top of the main branch.
  • I ran npm test and all tests passed.
  • I added test coverages if relevant.

Description

Remove the use of the proxy if Mozilla VPN inactive, still load page in the dedicated container. Without this fix, infinite page load happen on custom location proxied containers if Mozilla VPN is inactive (more info on #2570).

To reproduce:

  • Assign a custom VPN location to a container.
  • Globally disable Mozilla VPN.
  • Open a page with this container.
  • The page will load indefinitely.

Type of change

  • Bug fix
  • New feature
  • Major change (fix or feature that would cause existing functionality to work differently than in the current version)
    • The container will not use proxy even if it is configured to work behind a proxy when Mozilla VPN is inactive (globally disabled or not installed).

Tag issues related to this pull request:

Remove the use of the proxy if Mozilla VPN inactive, still load page in the dedicated container

fix mozilla#2570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant