Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going over the code to look at writing up some PRs and stumbled across 2 small easily corrected issues:
resolve()
being called twice, which is meaningless.Note that I’ve checked that using else for fallback/function exit is OK per style, see e.g.
multi-account-containers/src/js/background/assignManager.js
Lines 16 to 20 in 60b40a2
getByContainer()
which doesn’t exist (there is agetAssignedSites()
which in turn calls_getByContainer()
)