Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply sorting in page action menu too #2559

Closed
wants to merge 1 commit into from

Conversation

Cimbali
Copy link

@Cimbali Cimbali commented Aug 3, 2023

Quite simple, the page action menu was not sorted. This PR applies the sort, to be coherent with other displays of the containers.

@dannycolin
Copy link
Collaborator

Thanks a lot for your contribution. However, pageAction is deprecated in the new webextension API (Manifest v3). This means that browsers are going to remove the pageAction feature and we will need to remove it from Multi-Account Containers. See #2477

If there's any other feature you'd like to work on, please feel free to get in touch with us. You can ping me on a specific issue or join our matrix room #containers:mozilla.org on chat.mozilla.org (See https://wiki.mozilla.org/Matrix for instructions).

@dannycolin dannycolin closed this Sep 5, 2023
@Cimbali
Copy link
Author

Cimbali commented Sep 6, 2023

Yes actually it’s not even the list I was looking to sort, which is the one when long-pressing the “+” button for new tabs. But that one is not handled by MAC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants