Swap innerHTML to document.createFragment for pageAction/popup #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxxcrawford
changed the title
maxxcrawford
changed the title
maxxcrawford
changed the title
|
@maxxcrawford What do you think of completely removing pageAction right now? See #2477. |
maxxcrawford
force-pushed
the
unsafe-innerhtml-fix
branch
from
6e5e3cc
to
bf2859c
Compare
maxxcrawford
changed the title
maxxcrawford
force-pushed
the
unsafe-innerhtml-fix
branch
2 times, most recently
from
3ca33f4
to
ec80c78
Compare
maxxcrawford
changed the title
maxxcrawford
force-pushed
the
unsafe-innerhtml-fix
branch
from
b91d1f2
to
ec80c78
Compare
|
New container item is duplicated
There's now two "+ New Container" items. You can assign about:newtab to a container
Tab reopens in the assigned container.
There's an entry without a title corresponding to about:newtab |
…EN_IN_PICKER functions
maxxcrawford
force-pushed
the
unsafe-innerhtml-fix
branch
from
ec80c78
to
49d6db7
Compare
dannycolin
reviewed
May 29, 2023
| tableData.appendChild(spanMenuText); | ||
| tableRowMenuItem.appendChild(tableData); | ||
| tableMenu.appendChild(tableRowMenuItem); | ||
| divNewContainer.appendChild(tableMenu); |
There was a problem hiding this comment.
At L1236, we need to use divNewContainer.replaceChildren(tableMenu); to avoid creating a duplicate of the new container item everytime we enter MANAGE_CONTAINERS_PICKER panel.
|
Closing right now to stop blocking @dannycolin on other stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When submitting to AMO, there's a warning about using
innerHTML.Blocking L10N PR:mozilla-l10n/multi-account-containers-l10n#22This PR replaces all instances of it.
TODO:
Testing
This should have no visible changes in the UI. Check both the popup panel and the pageAction (in the URL bar). Both should appear/match
main.Screenshots
Confirmed with VPN set that the flag setting works/displays as expected:
