-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard subdomains - e.g. *.google.com #1500
Conversation
Whoa this is a cool feature. I'm a bit worried that this UX is not intuitive, and concerned about the breakage and/or privacy + security risks if users accidentally do this. I suppose breakage is un-likely, since an accidental wildcard assignment would make more sites share the same cookies. So, then the question is: if someone accidentally assigns wildcard subdomains to a container - have they lost a significant amount of their protection? I don't think so. But is it easy to reverse this operation? |
@groovecoder Glad you like it! :-) I've got this wildcard subdomains feature permanently installed (using my own build of the plugin). You can reverse the wildcard by clicking on the wildcard subdomain again, like so: By the way, you guys did (and are still doing) a great job with the plugin - thanks a lot! |
8a68609
to
9fa3ace
Compare
Can't wait for this to land! |
9fa3ace
to
7922a39
Compare
@dustymabe Yes I agree, it's such a useful feature! I've just refactored the code to make it a bit clearer for others to review. I'm hoping this might persuade one of the core devs to finally agree to merge it in...! |
9dfdc83
to
eb285cc
Compare
eb285cc
to
e6eff75
Compare
Great, this is a missing feature for now ! Can a last reviewer review this ? |
Bummed this didn't make it in the release the other day. Can I help by completing a review or in some other way? |
please merge this since with the new feature that supports 'limit to designated tabs' when loading google stuff I end up in a tab loading loop :( |
I need this feature so badly. Why is this PR nearly a year old? Is this project still maintained, or did Mozilla lay off all the maintainers? |
@jonathanKingston or @groovecoder What needs to be done to get this reviewed & merged? |
@jflattery Great that you want this feature. But have you tried Total Cookie Protection in Firefox 86? Maybe it means there is no longer such a strong need for this extension? |
Yes that is an awesome and welcome improvement to FF but it is only available to Strict mode if I'm not mistaken. |
Yes strict mode only. But you can add exceptions quite quickly by clicking the icon next to the location bar. It seems to work pretty well, and you know cross-site cookies are basically impossible unless you specifically allow them |
IMO this feature would really simplify a lot of the myriad other "container" extensions (Amazon, Reddit, Facebook, etc). |
When is this going to be implemented @groovecoder? |
Where can I find it? |
@BPower0036 I could put up my own build of the plugin for you to test out, but I think Mozilla should maintain stewardship of the plugin. So my build would just be a temporary "proof-of-concept" for you to try out. Would that help? Unfortunately, before I can share my build I would first need to merge in the 2+ years-worth of changes that have been made since I submitted this pull request. This may take some time, as there will no doubt be merge conflicts etc. |
@mckenfra A "proof-of-concept" would really help. |
@mckenfra I can't thank you a 1000 times for your work!! |
Closing in favor of the v2 in #2352. |
@dustymabe @groovecoder Per discussion on pull request #1475, I am resubmitting the pull request, having now rebased against the latest commits on master.
#473 Assign all subdomains of a domain to a container.
E.g. after adding
www.google.com
to a container, go to the edit container screen and click on thewww
part of the domain name to change it to___.google.com
. Then, any subsequent requests to subdomains such asmail.google.com
,calendar.google.com
ordrive.google.com
will all automatically open in the same container.Unit tests included.