feat(2fa): Add two-factor lib
#17937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbangert
reviewed
Oct 31, 2024
julianpoy
reviewed
Oct 31, 2024
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| export const generateBackupCodes = (count: number): string[] => { |
There was a problem hiding this comment.
A factory like this should be named BackupCodeFactory. Typically factories should be for complex types rather than simple types like the below, since they should always be TypeNameFactory.
julianpoy
reviewed
Oct 31, 2024
| getBackupCodes(userId: string): string[]; | ||
| } | ||
|
|
||
| export class BackupCodeManager { |
There was a problem hiding this comment.
Are these intended to be consumed by NestJS? If so, we should add the @Injectable decorator
julianpoy
reviewed
Oct 31, 2024
| export class BackupCodeManager { | ||
| constructor(private readonly backupCodeRepository: BackupCodeRepository) {} | ||
|
|
||
| hasBackupCodes(userId: string): { hasBackupCodes: boolean; count: number } { |
There was a problem hiding this comment.
Perhaps rename to getCountForUserId? This method is implicitly part of the BackupCodeManager class so doesn't need the name of the class within the class.
vbudhram
changed the title
backup-code libstwo-factor lib
vbudhram
force-pushed
the
fxa-10332
branch
2 times, most recently
from
eaeeea8
to
68b233f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
BackupCodeManagerclasshasRecoveryCodesIssue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-10332
Checklist
Notes
The linked issue mentions the nx lib should be
2fa, but nx wont let you create a lib starting with a number. Opted fortwo-factorinstead.