Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(settings,content,auth): Add account uid to gling pings #17584

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Sep 12, 2024

Because

  • We can decorate glean pings with raw uid

This pull request

  • Adds account uid (when available) to glean pings

Issue that this pull request solves

Closes: FXA-10321

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Asides from tests, I was able to manually validate account_uid was added to pings.

@dschom dschom requested a review from a team as a code owner September 12, 2024 00:29
@dschom dschom requested a review from chenba September 12, 2024 00:29
@@ -3,6 +3,21 @@
$schema: moz://mozilla.org/schemas/glean/metrics/2-0-0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if subplat-backend should also be updated, but I went ahead and added for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@chenba chenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's use user_id like you originally planned. Thanks!

@dschom dschom merged commit b5636bc into main Sep 13, 2024
26 checks passed
@dschom dschom deleted the FXA-10321 branch September 13, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants