Stringify webchannel event details on Thunderbird as well as Firefox #17528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-running from failed |
|
maybe a rebase? I'm not sure why it would be timing out |
chenba
force-pushed
the
tb-strigify-webchannel
branch
from
9de6d50
to
a583062
Compare
… well as Firefox Because: - the Gecko team want to [remove the webchannel whitelist preference](https://bugzilla.mozilla.org/show_bug.cgi?id=1275612), and - we want to stop using `general.useragent.compatMode.firefox` to add Firefox/x.y to Thunderbird's user-agent string This commit: - changes the user-agent parsing code to detect Thunderbird, and - uses that to fix a block which breaks webchannels on Thunderbird
chenba
force-pushed
the
tb-strigify-webchannel
branch
from
a583062
to
e2fef1e
Compare
chenba
commented
Sep 10, 2024
| @@ -122,8 +122,9 @@ function formatEventDetail(win, eventDetail) { | |||
| // See https://bugzilla.mozilla.org/show_bug.cgi?id=1275616 and | |||
| // https://bugzilla.mozilla.org/show_bug.cgi?id=1238128 | |||
| if ( | |||
| (userAgent.isFirefoxDesktop() || userAgent.isFirefoxAndroid()) && | |||
| userAgent.browser.version >= 50 | |||
There was a problem hiding this comment.
@darktrojan the test failures were caused by the removal of the browser version condition. I've restored it to the predicate, as my attempt at updating the related code became more time consuming than I expected, and this is a quicker fix.
There was a problem hiding this comment.
Really? Everything passed when I rebased it. That's weird. Oh well, as long as it works, and it appears to work.
Thanks!
chenba
changed the title
4 tasks
vbudhram
approved these changes
Sep 10, 2024
clouserw
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this was opened to run CI for #17518. But due to time zone differences, FxA fixed the issue that was causing the test failures here. See #17518 for its original description.
closes FXA-10411