New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task(admin-panel): Upgrade react-scripts from ^4.0.3 to ^5.0.1 #13494

Closed

dschom wants to merge 2 commits into main from FXA-5368-upgrade-react-scripts-from-4-0-3-to-5-0-1-fxa-admin-panel

Contributor

dschom commented Jun 29, 2022

Because

Package upgrade needed

This pull request

Upgrades react scripts
Changes react scripts to a dev dependency

Issue that this pull request solves

Closes: #13355

Checklist

Put an x in the boxes that apply

My commit is GPG signed.
If applicable, I have modified or added tests which pass locally.
I have added necessary documentation (if appropriate).
I have verified that my changes render correctly in RTL (if appropriate).


          task(admin-panel): Upgrade react-scripts from ^4.0.3 to ^5.0.1

Contributor

fxa-bananafox bot commented Jun 29, 2022

I got u dschom. 💯


          chore(deps): updated yarn.lock

998b190

Contributor

LZoog commented Jun 30, 2022 •

edited

Loading

That error is one that we throw in rescripts.js FWIW which is different than the one I saw in #13147 🤔

dschom closed this

dschom deleted the FXA-5368-upgrade-react-scripts-from-4-0-3-to-5-0-1-fxa-admin-panel branch

August 1, 2022 22:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet