Skip to content

Commit

Permalink
Merge pull request #17710 from mozilla/FXA-10376
Browse files Browse the repository at this point in the history
task(CAD): Update 'Start browsing' to 'Manage your account'
  • Loading branch information
LZoog authored Sep 27, 2024
2 parents bf8164e + 29c9818 commit 2f5fbe7
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 11 deletions.
4 changes: 2 additions & 2 deletions packages/functional-tests/pages/connectAnotherDevice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ export class ConnectAnotherDevicePage extends BaseLayout {
);
}

get startBrowsingButton() {
return this.page.getByRole('link', { name: 'Start browsing' });
get manageYourAccountButton() {
return this.page.getByRole('link', { name: 'Manage your account' });
}

get installFxDesktop() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<a id="sync-firefox-devices" href="{{{pairingUrl}}}" class="cta-primary cta-xl" data-flow-event="link.pair" role="button">{{#t}}Connect another device{{/t}}</a>
</div>
<div class="mt-5 text-center">
<a id="cad-not-now" class="link-blue" href="/settings">{{#t}}Start browsing{{/t}}</a>
<a id="cad-not-now" class="link-blue" href="/settings">{{#t}}Manage your account{{/t}}</a>
</div>
{{/isSignedIn}}
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
{{#isSync}}
<p class="account-ready-service">{{{escapedReadyToSyncText}}}</p>
<div class="button-row">
<button class="primary-button btn-start-browsing">{{#t}}Start browsing{{/t}}</button>
<button class="primary-button btn-start-browsing">{{#t}}Manage your account{{/t}}</button>
</div>
{{/isSync}}

Expand Down
2 changes: 1 addition & 1 deletion packages/fxa-content-server/app/tests/spec/views/ready.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ describe('views/ready', function () {
});
});

it('shows the `Start browsing` for Sync', () => {
it('shows the `Manage your account` for Sync', () => {
createView(VerificationReasons.SIGN_UP);
sinon.stub(relier, 'isSync').callsFake(() => true);

Expand Down
2 changes: 1 addition & 1 deletion packages/fxa-settings/src/components/Ready/en.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

reset-password-complete-header = Your password has been reset
ready-complete-set-up-instruction = Complete setup by entering your new password on your other { -brand-firefox } devices.
ready-start-browsing-button = Start browsing
manage-your-account-button = Manage your account
# This is a string that tells the user they can use whatever service prompted them to reset their password or to verify their email
# Variables:
# { $serviceName } represents a product name (e.g., Mozilla VPN) that will be passed in as a variable
Expand Down
4 changes: 2 additions & 2 deletions packages/fxa-settings/src/components/Ready/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ const Ready = ({
</p>
</FtlMsg>
<div className="flex justify-center mx-auto mt-6">
<FtlMsg id="ready-start-browsing-button">
<FtlMsg id="manage-your-account-button">
<button className="cta-primary cta-xl" onClick={startBrowsing}>
Start browsing
Manage your account
</button>
</FtlMsg>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('ResetPasswordWithRecoveryKeyVerified', () => {
// bundle = await getFtlBundle('settings');
// });

const startBrowsingText = 'Start browsing';
const startBrowsingText = 'Manage your account';
const signedInText = 'You’re now ready to use account settings';
const singedOutText = 'Your account is ready!';
const syncText =
Expand Down
2 changes: 1 addition & 1 deletion packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1727,7 +1727,7 @@ cad:
startbrowsing_submit:
type: event
description: |
User clicks "Start browsing" on "Connect another device page"
User clicks "Manage your account" on "Connect another device page". This CTA used to be "Start browsing".
send_in_pings:
- events
notification_emails:
Expand Down
3 changes: 2 additions & 1 deletion packages/fxa-shared/metrics/glean/web/cad.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
import EventMetricType from '@mozilla/glean/private/metrics/event';

/**
* User clicks "Start browsing" on "Connect another device page"
* User clicks "Manage your account" on "Connect another device page". This CTA
* used to be "Start browsing".
*
* Generated from `cad.startbrowsing_submit`.
*/
Expand Down

0 comments on commit 2f5fbe7

Please sign in to comment.