feat(nimbus): Draft/Preview/Review workflow #11932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashikakhurana
requested review from
jaredlockhart and
brennie
as code owners
yashikakhurana
changed the title
|
wait for review, fixing some layouts |
jaredlockhart
requested changes
Dec 11, 2024
Comment on lines
338
to
340
| generate_nimbus_changelog( | ||
| experiment, self.request.user, self.get_changelog_message() | ||
| ) |
There was a problem hiding this comment.
Why add this here? This is already done by NimbusChangeLogFormMixin?
There was a problem hiding this comment.
oh if I am overriding the save method, I noticed that it is not generating the changelogs, so for that, I needed to explicitly called the generate changelogs method
Comment on lines
+4
to
+11
| <svg class="align-top" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| fill="currentColor" | ||
| viewBox="0 0 16 16" | ||
| width="16" | ||
| height="16"> | ||
| <path d="M13.485 1.4a.5.5 0 0 1 .035.71L6.543 9.793 3.379 6.93a.5.5 0 1 1 .708-.707l2.1 2.1 6.514-7.1a.5.5 0 0 1 .707-.035z" /> | ||
| </svg> |
There was a problem hiding this comment.
We should be able to use fontawesome here?
| @@ -264,3 +271,93 @@ class UnsubscribeView( | |||
| ): | |||
| form_class = UnsubscribeForm | |||
| template_name = "nimbus_experiments/subscribers_list.html" | |||
|
|
|||
| class TimelineAndControlsMixin: | |||
There was a problem hiding this comment.
So I think a different way to do this is to move all this logic directly into the summary template, and then use hx-select and hx-target to just update the controls/timeline, rather than doing logic in the views here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
We want to include workflow on the new summary page:
This commit
Fixes #11757
Screen.Recording.2024-12-11.at.10.24.37.AM.mov