Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(project): disable signed urls #11652

Merged
merged 1 commit into from
Oct 30, 2024
Merged

bug(project): disable signed urls #11652

merged 1 commit into from
Oct 30, 2024

Conversation

jaredlockhart
Copy link
Collaborator

@jaredlockhart jaredlockhart commented Oct 30, 2024 •
edited
Loading

Because

  • As part of the migration to GCPV2 we discovered that django-storages has an open bug for supporting signed urls
  • We generate GCS bucket urls for uploaded images (ie branch screenshots)
  • To display those screenshots we need URLs
  • Using signed URLs is not supported on the new GCPV2 deployment
  • We can disable signed URLs altogether until it is supported by django-storages

This commit

  • Disables signed urls

fixes #11651

@jaredlockhart
bug(project): disable signed urls
7b57f3f 
Because

* To migrate to GCPV2 we must disable signed urls

This commit

* Disables signed urls

fixes #11651
@jaredlockhart jaredlockhart marked this pull request as draft October 30, 2024 18:53
@four-keys-mozilla four-keys-mozilla bot temporarily deployed to prod October 30, 2024 19:12 Inactive
@four-keys-mozilla four-keys-mozilla bot temporarily deployed to stage October 30, 2024 19:14 Inactive
@jaredlockhart jaredlockhart marked this pull request as ready for review October 30, 2024 19:31
@jaredlockhart jaredlockhart added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 1e10248 Oct 30, 2024
17 checks passed
@jaredlockhart jaredlockhart deleted the 11651 branch October 30, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewilli mikewilli mikewilli approved these changes

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

@brennie brennie Awaiting requested review from brennie brennie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable signed urls for uploaded images
2 participants
@jaredlockhart @mikewilli