Reviewer Tools Pastebin Re-implementation #22640

chrstinalin · 2024-09-04T19:38:42Z

Description

Adds an AttachmentLog model and ability to either upload a file (currently limited to .txt) or directly paste a build log (stored as a .txt file) from any reviewer action. Attachments can then be downloaded in the add-on history.

Context

Testing

Enable the enable-activity-log-attachments waffle switch.
Log in with [email protected] (for ease of navigation).
Submit a new add-on.
Make a reviewer reply (or any other action) from the review action section and include an attachment.

Checklist

Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
Successfully verified the change locally.
The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
Add before and after screenshots (Only for changes that impact the UI).

…ions)

…ed query number assertion

…o pastebin-feature

src/olympia/reviewers/templates/reviewers/review.html

src/olympia/reviewers/forms.py

src/olympia/reviewers/tests/test_utils.py

src/olympia/reviewers/tests/test_views.py

src/olympia/reviewers/utils.py

eviljeff · 2024-09-11T17:33:36Z

src/olympia/urls.py

@@ -43,6 +44,8 @@
    re_path(r'^uploads/', include(upload_patterns)),
    # Downloads.
    re_path(r'^downloads/', include(download_patterns)),
+    # Activity.
+    re_path(r'^activity/', include(attachment_patterns)),


I'd lean towards putting the url under developers/ but don't know if @diox has a counter opinion.

activity/ makes slightly more sense to me, it's an activity attachment after all, and it's available to reviewers, not just developers.

The cleaner way would then be to:

Move the existing activity/urls.py to activity/api_urls.py

Re-create the activity/urls.py file and add a fresh urlpatterns definition to it with that new URL

Include it with re_path(r'activity/', include('olympia.activity.urls')) here.

Note that you would also need to add activity to SUPPORTED_NONAPPS and SUPPORTED_NONLOCALES settings (as well as the equivalent addons-frontend config variables)

(I was mainly thinking of a way of avoiding having to add another top level app/folder to configurations everywhere)

It's a little bit annoying but I think that's worth doing to avoid for consistency (and the less reviewers functionality depend on developer URLs/views/etc the better IMHO)

Note that you would also need to add activity to SUPPORTED_NONAPPS and SUPPORTED_NONLOCALES settings (as well as the equivalent addons-frontend config variables)

I did notice that doing this caused the download link to no longer work, but I'm assuming its due to the changes not being synced?

src/olympia/activity/models.py

src/olympia/activity/views.py

eviljeff · 2024-09-11T17:49:47Z

Also, looking through the other tickets in the epic I don't see anywhere that explicitly mentions adding the link to the emails we send out. This patch doesn't add anything, and the developer hub ticket doesn't have it as a deliverable either.

chrstinalin · 2024-09-11T18:07:28Z

Also, looking through the other tickets in the epic I don't see anywhere that explicitly mentions adding the link to the emails we send out. This patch doesn't add anything, and the developer hub ticket doesn't have it as a deliverable either.

Whoops, that's on me. It slipped my mind when I was making the tickets. I've added a new ticket mozilla/addons#15018 for the email.

…o pastebin-feature

…a/addons-server#22640

src/olympia/reviewers/utils.py

src/olympia/reviewers/tests/test_views.py

src/olympia/reviewers/forms.py

src/olympia/activity/urls.py

…o pastebin-feature

eviljeff

r+wc - just two minor things to change.

src/olympia/reviewers/forms.py

src/olympia/reviewers/utils.py

…a/addons-server#22640 (#13202)

* Added view attachment link on DevHub in relation to #22640 * lint * renamed attachment_link to attachment_url * js attachment_url * test update * doc * test * dont hardcode test * lint * limit queries * Use correct pk in reverse

Added pastebin reimplementation on reviewer tools side

3a2a909

chrstinalin marked this pull request as draft September 4, 2024 19:38

chrstinalin changed the title ~~Pastebin feature~~ Reviewer Tools Pastebin Re-implementation Sep 4, 2024

chrstinalin force-pushed the pastebin-feature branch from ff5e8c7 to 3a2a909 Compare September 5, 2024 12:25

chrstinalin added 6 commits September 5, 2024 08:26

make lint

7c649e0

Moved attachment upload box to own section (and available for all act…

5952891

…ions)

Fixed css for textareas, returned datetime-wrapper

1ed8eee

Missing assignment

febd7bc

Updated naming for files, limited to .txt and .zip, temporarily updat…

2c1b8f1

…ed query number assertion

added waffle enable-activity-log-attachments for user facing menus;

eef5a68

chrstinalin force-pushed the pastebin-feature branch 2 times, most recently from eef5a68 to 2c1b8f1 Compare September 9, 2024 17:32

chrstinalin added 3 commits September 10, 2024 11:24

testing

eb23dad

corrected test

7659b9b

Removed zip allowance

1786f89

chrstinalin force-pushed the pastebin-feature branch from 1786f89 to febd7bc Compare September 10, 2024 15:36

chrstinalin added 7 commits September 10, 2024 11:45

Merge branch 'master' of https://github.com/mozilla/addons-server int…

64f6cae

…o pastebin-feature

migration conflict

bd644c8

test (temp)

53ef928

import

110cf50

remove git_extraction.py from pr

577198d

???

1b7ac31

numQueries

d90e4de

chrstinalin marked this pull request as ready for review September 10, 2024 19:38

chrstinalin requested review from a team and eviljeff and removed request for a team September 10, 2024 19:39

Merge branch 'master' of https://github.com/mozilla/addons-server int…

95428c9

…o pastebin-feature

eviljeff requested changes Sep 11, 2024

View reviewed changes

chrstinalin added 5 commits September 11, 2024 14:45

Merge branch 'master' of https://github.com/mozilla/addons-server int…

b5be291

…o pastebin-feature

Merge branch 'master' of https://github.com/mozilla/addons-server int…

1240be4

…o pastebin-feature

review changes

68421ef

lint

6f55a18

prettier

e464c75

chrstinalin added a commit to chrstinalin/addons-frontend that referenced this pull request Sep 12, 2024

Sync constants SUPPORTED_NONLOCALES and SUPPORTED_NONAPPS with mozill…

53b3172

…a/addons-server#22640

chrstinalin mentioned this pull request Sep 12, 2024

Sync constants SUPPORTED_NONLOCALES and SUPPORTED_NONAPPS mozilla/addons-frontend#13202

Merged

chrstinalin requested a review from eviljeff September 12, 2024 21:27

eviljeff requested changes Sep 13, 2024

View reviewed changes

src/olympia/reviewers/utils.py Outdated Show resolved Hide resolved

src/olympia/reviewers/tests/test_views.py Outdated Show resolved Hide resolved

src/olympia/reviewers/forms.py Show resolved Hide resolved

src/olympia/activity/urls.py Outdated Show resolved Hide resolved

chrstinalin added 2 commits September 13, 2024 08:39

review changes

88484a0

lol lint

b425ff8

chrstinalin requested a review from eviljeff September 13, 2024 12:58

Merge branch 'master' of https://github.com/mozilla/addons-server int…

7017019

…o pastebin-feature

chrstinalin added a commit to chrstinalin/addons-server that referenced this pull request Sep 13, 2024

Added view attachment link on DevHub in relation to mozilla#22640

8bc95da

chrstinalin mentioned this pull request Sep 13, 2024

DevHub Pastebin Re-implementation #22664

Merged

5 tasks

eviljeff approved these changes Sep 13, 2024

View reviewed changes

src/olympia/reviewers/forms.py Outdated Show resolved Hide resolved

src/olympia/reviewers/utils.py Outdated Show resolved Hide resolved

review comment

24ed82f

chrstinalin merged commit c6026f6 into mozilla:master Sep 13, 2024
31 checks passed

chrstinalin added a commit to mozilla/addons-frontend that referenced this pull request Sep 13, 2024

Sync constants SUPPORTED_NONLOCALES and SUPPORTED_NONAPPS with mozill…

c09adf0

…a/addons-server#22640 (#13202)

chrstinalin mentioned this pull request Sep 16, 2024

Allow Zip Files to be Uploaded as Attachment #22670

Merged

3 tasks

ioanarusiczki mentioned this pull request Sep 25, 2024

[Task]: Reviewer Tools Pastebin Re-implementation mozilla/addons#14997

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reviewer Tools Pastebin Re-implementation #22640

Reviewer Tools Pastebin Re-implementation #22640

chrstinalin commented Sep 4, 2024 •

edited

Loading

eviljeff Sep 11, 2024

diox Sep 12, 2024

eviljeff Sep 12, 2024

diox Sep 12, 2024

chrstinalin Sep 12, 2024

eviljeff commented Sep 11, 2024

chrstinalin commented Sep 11, 2024

eviljeff left a comment

Reviewer Tools Pastebin Re-implementation #22640

Reviewer Tools Pastebin Re-implementation #22640

Conversation

chrstinalin commented Sep 4, 2024 • edited Loading

Description

Context

Testing

Checklist

eviljeff Sep 11, 2024

Choose a reason for hiding this comment

diox Sep 12, 2024

Choose a reason for hiding this comment

eviljeff Sep 12, 2024

Choose a reason for hiding this comment

diox Sep 12, 2024

Choose a reason for hiding this comment

chrstinalin Sep 12, 2024

Choose a reason for hiding this comment

eviljeff commented Sep 11, 2024

chrstinalin commented Sep 11, 2024

eviljeff left a comment

Choose a reason for hiding this comment

chrstinalin commented Sep 4, 2024 •

edited

Loading