Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-10205 [Swiftlint] Resolve 1 implicitly_unwrapped_optional violations in HomePanelType #23841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tonell-m
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Continuing resolving implicitly_unwrapped_optional violations in order to enable the rule for further developments.

Here I force unwrap the created aboutUrl but since it was implicitly unwrapped right after to create internalUrl it's not an extra liability.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@tonell-m tonell-m requested a review from a team as a code owner December 18, 2024 09:39
@tonell-m tonell-m requested a review from Cramsden December 18, 2024 09:39
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.77%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 32.09

File Coverage
HomePanelType.swift 100.0%

Generated by 🚫 Danger Swift against 17b92ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants