Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-10205 [Swiftlint] Resolve 1 implicitly_unwrapped_optional violations in BaseAlphaStackView #23837

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor FXIOS-10205 [Swiftlint] Resolve 1 implicitly_unwrapped_optional violations in BaseAlphaStackView #23837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
812cd14
Resolve warnings in BaseAlphaStackView
tonell-m Dec 18, 2024
723ea46
Update filename to match class name
tonell-m Dec 18, 2024
ff623ca
Update filepath in xcode proj
tonell-m Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions firefox-ios/Client.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@
8AEAD9F32C3D7B3E001A2C5A /* FeatureFlagsSettings.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8AEAD9F22C3D7B3E001A2C5A /* FeatureFlagsSettings.swift */; };
8AEAD9F52C3D7BA9001A2C5A /* FeatureFlagsDebugViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8AEAD9F42C3D7BA9001A2C5A /* FeatureFlagsDebugViewController.swift */; };
8AEAD9F92C3DB0CD001A2C5A /* MicrosurveyTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8AEAD9F62C3DB0BF001A2C5A /* MicrosurveyTests.swift */; };
8AED23C527AC1F9500DE7E97 /* BaseContentStackView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8AED23C427AC1F9500DE7E97 /* BaseContentStackView.swift */; };
8AED23C527AC1F9500DE7E97 /* BaseAlphaStackView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8AED23C427AC1F9500DE7E97 /* BaseAlphaStackView.swift */; };
8AED868328CA3B3400351A50 /* BookmarkPanelViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8AED868228CA3B3400351A50 /* BookmarkPanelViewModelTests.swift */; };
8AEDB11529F9F00400F2A53B /* SceneContainer.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8AEDB11429F9F00400F2A53B /* SceneContainer.swift */; };
8AEE284B276A973400C7104D /* RatingPromptManagerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8AEE284A276A973400C7104D /* RatingPromptManagerTests.swift */; };
Expand Down Expand Up @@ -7632,7 +7632,7 @@
8AEAD9F22C3D7B3E001A2C5A /* FeatureFlagsSettings.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FeatureFlagsSettings.swift; sourceTree = "<group>"; };
8AEAD9F42C3D7BA9001A2C5A /* FeatureFlagsDebugViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FeatureFlagsDebugViewController.swift; sourceTree = "<group>"; };
8AEAD9F62C3DB0BF001A2C5A /* MicrosurveyTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MicrosurveyTests.swift; sourceTree = "<group>"; };
8AED23C427AC1F9500DE7E97 /* BaseContentStackView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BaseContentStackView.swift; sourceTree = "<group>"; };
8AED23C427AC1F9500DE7E97 /* BaseAlphaStackView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BaseAlphaStackView.swift; sourceTree = "<group>"; };
8AED868228CA3B3400351A50 /* BookmarkPanelViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BookmarkPanelViewModelTests.swift; sourceTree = "<group>"; };
8AEDB11429F9F00400F2A53B /* SceneContainer.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SceneContainer.swift; sourceTree = "<group>"; };
8AEDFE832C9DAB9C00821359 /* FennecTesting.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = FennecTesting.xcconfig; sourceTree = "<group>"; };
Expand Down Expand Up @@ -12009,7 +12009,7 @@
isa = PBXGroup;
children = (
E17496362991A2480096900A /* SwiftUI */,
8AED23C427AC1F9500DE7E97 /* BaseContentStackView.swift */,
8AED23C427AC1F9500DE7E97 /* BaseAlphaStackView.swift */,
43AB6F9E25DC53D20016B015 /* LegacyLabelButtonHeaderView.swift */,
8A36BE2829EDBC6900AC1C5C /* ContentContainer.swift */,
8ACE9BFA2A54A010001E7A73 /* ExpandButtonState.swift */,
Expand Down Expand Up @@ -16359,7 +16359,7 @@
9636D92827F5D72D00771F5E /* GleanPlumbMessageManager.swift in Sources */,
C80685D126A0C93900DCD895 /* UserResearch.swift in Sources */,
B2999FF52B194AB200F0FEC1 /* FormAutofillHelperError.swift in Sources */,
8AED23C527AC1F9500DE7E97 /* BaseContentStackView.swift in Sources */,
8AED23C527AC1F9500DE7E97 /* BaseAlphaStackView.swift in Sources */,
C8699131289176A5007ACC5C /* WallpaperNetworking.swift in Sources */,
5A271ABD2860B0D700471CE4 /* WebServerUtil.swift in Sources */,
964FA97528A1A8F20024BB3B /* ContextualHintEligibilityUtility.swift in Sources */,
Expand Down
2 changes: 1 addition & 1 deletion ...end/Components/BaseContentStackView.swift → ...ntend/Components/BaseAlphaStackView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class BaseAlphaStackView: UIStackView, AlphaDimmable, ThemeApplicable {

// MARK: - Spacer view

private var keyboardSpacerHeight: NSLayoutConstraint!
private var keyboardSpacerHeight: NSLayoutConstraint?
private var keyboardSpacer: UIView?

func addKeyboardSpacer(spacerHeight: CGFloat) {
Expand Down