Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-7642 [v120] Update of Fakespot design and string to accomodate for localizations (backport #17131) #17242

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 9, 2023

This is an automatic backport of pull request #17131 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…comodate for localizations (#17131)

* Update string

* Update layout to allow for taller buttons

* Update string comment

* Fix layout in LinkButton

(cherry picked from commit f0af8ae)
@mergify mergify bot requested a review from a team as a code owner November 9, 2023 14:47
@mergify mergify bot requested review from yoanarios and removed request for a team November 9, 2023 14:47
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.1%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 32.56

File Coverage
FakespotOptInCardView.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 482127c

@thatswinnie thatswinnie merged commit 14088ea into release/v120 Nov 9, 2023
9 of 10 checks passed
@thatswinnie thatswinnie deleted the mergify/bp/release/v120/pr-17131 branch November 9, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants