This repository has been archived by the owner on Nov 13, 2017. It is now read-only.
Enable Octomap diff #636
Open
Enable Octomap diff #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2016
Closed
| @@ -122,6 +122,12 @@ class OccupancyMapMonitor | |||
| return active_; | |||
| } | |||
|
|
|||
| /** \brief Enable sending diffs of the occupancy map */ | |||
| void enableOctomapDiff(bool enable) { octomap_diff_enable = enable; } | |||
There was a problem hiding this comment.
brackets, code line, etc should be on separate lines like the rest of this file and per ros style guidelines
There was a problem hiding this comment.
Should this function be named setOctomapDiff(bool enable)?
Personally, I find enableXYZ(false); calls a bit weird. No hard feelings though.
There was a problem hiding this comment.
+1 sounds better to me.
|
+1 |
dornhege
force-pushed
the
cbrew_octomap_diff
branch
from
5b44738
to
4591ae5
Compare
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially #602 by @TheBrewCrew, which now also handles loading maps via the service correctly.
When the ROS parameter /move_group/octomap_diff is enabled, change detection is the OctoMap is enabled and only diffs are send instead of complete OcTrees.
This requires moveit/moveit_core#302 to work.