Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update planning pipeline configs #189

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Oct 12, 2023

Config changes necessary for moveit/moveit2#2429

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the critical thing here is that we'll need to cut a Humble branch of this repo before the breaking changes get in... and ensure that the humble branch of the tutorials uses this repo's humble branch as well.

Just some bookkeeping that would be good to do before merging these.

@tylerjw
Copy link
Member

tylerjw commented Nov 21, 2023

we'll need to cut a Humble branch of this repo

Humble branch here already exists. I think we can go ahead and merge these.

@tylerjw tylerjw marked this pull request as ready for review November 21, 2023 15:09
@tylerjw tylerjw merged commit 7162dcd into moveit:ros2 Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants