Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert debug warning #884

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Dec 3, 2021

This is a commit that I extracted form #452. The warning should be a debug message, it seems to have been merged as part of some verbose debugging attempt. Related note: Are we missing best practices on how to use and filter log messages properly? I've seen temporarily increased logger levels like this quite often and it should not be necessary.

@henningkayser henningkayser self-assigned this Dec 3, 2021
@JafarAbdi
Copy link
Member

Are we missing best practices on how to use and filter log messages properly? I've seen temporarily increased logger levels like this quite often and it should not be necessary.

As far as I know, there's no easy way to do it, a couple months ago I made a PR that hopefully will make our life easier. unfortunately, it still not merged yet

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #884 (4dd5fa0) into main (cf62f75) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   56.81%   56.83%   +0.02%     
==========================================
  Files         200      200              
  Lines       21659    21659              
==========================================
+ Hits        12304    12307       +3     
+ Misses       9355     9352       -3     
Impacted Files Coverage Δ
moveit_core/robot_model/src/joint_model_group.cpp 55.81% <0.00%> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.93% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf62f75...4dd5fa0. Read the comment docs.

@AndyZe AndyZe merged commit 42afeea into moveit:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants